Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds enterprise_config_resource_name field to cloudbuild trigger resource in order to support github enter… #13739

Merged
merged 1 commit into from
Feb 14, 2023
Merged

Adds enterprise_config_resource_name field to cloudbuild trigger resource in order to support github enter… #13739

merged 1 commit into from
Feb 14, 2023

Conversation

modular-magician
Copy link
Collaborator

…prise triggers

Resolves #9956

Adds github enterprise trigger support to cloud build triggers by adding github.enterprise_config_resource_name field.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

cloudbuild: added `github.enterprise_config_resource_name` field to `google_cloudbuild_trigger` resource

Derived from GoogleCloudPlatform/magic-modules#7236

@modular-magician
Adds enterprise_config_resource_name field to cloudbuild trigger reso…
c16a968 
…urce in order to support github enter… (hashicorp#7236)

* Adds enterprise_config_resource_name field to cloudbuild trigger resource in order to support github enterprise triggers

* Fix newline at EOF

---------

Co-authored-by: Mario Machado <[email protected]>
Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit b90bec5 into hashicorp:main Feb 14, 2023
@kuba-vodafone
Copy link

anyone knows when this change will be included in the release?

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setting a cloudbuild trigger from enterprise self hosted github
2 participants
@modular-magician @kuba-vodafone